[libcxx-commits] [PATCH] D97176: [libcxx] adds concepts std::equality_comparable[_with]

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 4 17:17:57 PST 2021


cjdb added a comment.

In D97176#2604693 <https://reviews.llvm.org/D97176#2604693>, @Quuxplusone wrote:

> LGTM!
> (Obnitpick: I see a mix of `auto operator==` and `bool operator==`. Is `auto operator==` good C++20 style? Anyway, I don't think it ever matters for this particular test.)

`auto operator==(...) = default` is ill-formed (it //must// be `bool`), but `auto operator<=>(...) = default` is allowed (the compiler will do magic to work out which of the three blessed types it'll be).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97176/new/

https://reviews.llvm.org/D97176



More information about the libcxx-commits mailing list