[libcxx-commits] [PATCH] D97539: [libcxx] Implement semaphores for windows

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

I trust other reviewers with the implementation.

I've said it before, but I would be happier if we had a tester setup for windows. @rnk @amccarth Do any of you think that would be something feasible? The BuildKite setup is really easy to interface with.



================
Comment at: libcxx/include/__threading_support:153
+#if defined(_LIBCPP_HAS_THREAD_API_WIN32)
+# define _LIBCPP_SEMAPHORE_MAX (numeric_limits<long>::max())
+#endif
----------------
Let's use `::std::numeric_limits<long>::max()`, just as good hygiene for a macro.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97539/new/

https://reviews.llvm.org/D97539