[libcxx-commits] [PATCH] D89943: [libcxx] [test] Fix path.decompose for windows
Arthur O'Dwyer via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Mar 4 15:08:55 PST 2021
Quuxplusone added inline comments.
================
Comment at: libcxx/test/std/input.output/filesystems/class.path/path.member/path.decompose/path.decompose.pass.cpp:95
, {"//net/foo", {"/", "net", "foo"}, "/", "", "/", "net/foo", "/net", "foo"}
+#endif
, {"///foo///", {"/", "foo", ""}, "/", "", "/", "foo///", "///foo", ""}
----------------
Conspicuously missing here: `"//net/"`. Any thoughts on adding it as part of this patch?
(LGTM modulo I don't actually get what's going on here. Is it that this test is currently red on Windows and you're just adding the correct test code to make it green on Windows? You don't have to remove any XFAILs or anything as part of this patch?)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89943/new/
https://reviews.llvm.org/D89943
More information about the libcxx-commits
mailing list