[libcxx-commits] [PATCH] D97365: [libc++] [C++2b] [P1682] Add to_underlying.

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius marked an inline comment as done.
curdeius added inline comments.


================
Comment at: libcxx/test/std/utilities/utility/utility.underlying/to_underlying.pass.cpp:61
+
+  return true;
+}
----------------
Quuxplusone wrote:
> I would be interested to see how `std::to_underlying(s.bf)` works on an enum bit-field. I know that's more of a core-language-trivia issue than a library-trivia issue, but it'd still be nice to have a test case.
> 
> And if you can construct a test case for the ADL issue (maybe involving `enum X<Holder<Incomplete>>::E`? I'd have to look up the rules again), that'd be cool (but not a blocker).
Done.
I've already started answering that I cannot find a test case for that and then I found it :).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97365/new/

https://reviews.llvm.org/D97365