[libcxx-commits] [PATCH] D61771: Comparing Unordered Containers (P0809)

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added a comment.

It would be cool to land it. I know that Arthur marked it as "Nothing To Do" already, but to the best of my knowledge there are no tests for that. And your tests seem exhaustive.

Nit: in the summary, the phrase "It also fixes issues with the current implementations." seems outdated.



================
Comment at: libcxx/test/std/containers/unord/unord.set/comp_different_hash.pass.cpp:106
+    assert(c5 == c4);
+    assert(c5 == c5);
+}
----------------
For completeness, you should test `operator!=` as well (here and in other tests).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61771/new/

https://reviews.llvm.org/D61771