[libcxx-commits] [PATCH] D97904: [libcxx] updates the feature-test macro generator

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 3 21:42:49 PST 2021


cjdb added a comment.

In D97904#2602288 <https://reviews.llvm.org/D97904#2602288>, @Quuxplusone wrote:

> Assuming you've verified that (after this patch) running `utils/generate_feature_test_macro_components.py` produces no git diffs, where (before this patch) it used to produce diffs, I'd assume this patch is good to go.

PTAL again.

> Maybe one of the other newly minted libc++ approvers can give it the libc++ stamp of approval. :)

Yes please! I didn't see @ldionne's email till after I put this up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97904/new/

https://reviews.llvm.org/D97904



More information about the libcxx-commits mailing list