[libcxx-commits] [PATCH] D97904: [libcxx] updates the feature-test macro generator

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 3 18:15:02 PST 2021


cjdb created this revision.
cjdb added reviewers: ldionne, EricWF, Quuxplusone.
Herald added a subscriber: arichardson.
cjdb requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

D97015 <https://reviews.llvm.org/D97015> didn't correctly update `generate_feature_test_macro_components.py`.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97904

Files:
  libcxx/utils/generate_feature_test_macro_components.py


Index: libcxx/utils/generate_feature_test_macro_components.py
===================================================================
--- libcxx/utils/generate_feature_test_macro_components.py
+++ libcxx/utils/generate_feature_test_macro_components.py
@@ -421,8 +421,8 @@
     "name": "__cpp_lib_math_constants",
     "values": { "c++20": 201907 },
     "headers": ["numbers"],
-    "depends": "defined(__cpp_concepts) && __cpp_concepts >= 201907L",
-    "internal_depends": "defined(__cpp_concepts) && __cpp_concepts >= 201907L",
+    "depends": "!defined(_LIBCPP_HAS_NO_CONCEPTS)",
+    "internal_depends": "!defined(_LIBCPP_HAS_NO_CONCEPTS)",
   }, {
     "name": "__cpp_lib_math_special_functions",
     "values": { "c++17": 201603 },


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97904.327983.patch
Type: text/x-patch
Size: 735 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210304/0cfad2df/attachment.bin>


More information about the libcxx-commits mailing list