[libcxx-commits] [PATCH] D97862: [libc++] Introduce __identity_t<T>

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 3 14:43:54 PST 2021


ldionne added a comment.

This is non-blocking, however I think it might be nicer to use `__identity_t` on the arguments of the constructors that need them instead of on the typedefs. Otherwise, it's really unclear *why* this convolution is needed. So for example, you could have

  unordered_multiset(size_type __n, const __identity_t<allocator_type>& __a)
          : unordered_multiset(__n, hasher(), key_equal(), __a) {}

Feel free to do it now, do it later, or not do it at all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97862/new/

https://reviews.llvm.org/D97862



More information about the libcxx-commits mailing list