[libcxx-commits] [PATCH] D80690: [RISCV] Support libunwind for riscv32

[Nico Weber via Phabricator via libcxx-commits]

thakis added inline comments.


================
Comment at: libunwind/src/Registers.hpp:3739
+# else
+#  error "Unsupported __riscv_xlen"
+# endif
----------------
I think you can't assume that `__riscv` stuff is defined down here. This is in a `__LIBUNWIND_TARGET_RISCV` block, which, if `_LIBUNWIND_IS_NATIVE_ONLY` is not defined (which it isn't in LIBUNWIND_ENABLE_CROSS_UNWINDING builds), is defined to 1.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80690/new/

https://reviews.llvm.org/D80690