[libcxx-commits] [PATCH] D97452: [libcxx] [test] Pass some windows environment variables through to test processes

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 2 12:25:58 PST 2021

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

In D97452#2597780 <https://reviews.llvm.org/D97452#2597780>, @mstorsjo wrote:

> [...]
> Consider cross testing (I do that, but that's further away in the upstreaming pipeline) - I don't want to pick up env vars blindly from the (unix) build env and pass them to the remote runner (windows), I just want the logic that creates a clean env to let some specifics through.
> Those setups use a variant of the existing ssh.py runner (which don't clear the env, only add vars to it), while run.py (for local execution) is the one that entirely wipe the env before adding the env vars that are requested.

I'm convinced. Indeed, it doesn't make any sense to forward env vars from the build host to the run host.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list