[libcxx-commits] [PATCH] D97742: [C++23] [P1518R2] Better CTAD behavior for containers with allocators

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added a comment.

This mostly LGTM but I haven't read it too carefully. Thanks for doing this, Arthur.



================
Comment at: libcxx/include/deque:1318
     deque(const deque& __c);
-    deque(const deque& __c, const allocator_type& __a);
+    deque(const deque& __c, const typename __identity<allocator_type>::type& __a);
 
----------------
I //think// all the compilers we that support support templated type aliases. WDYT about making this `deque(const deque& __c, const __identity_t<allocator_type>& __a);`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97742/new/

https://reviews.llvm.org/D97742