[libcxx-commits] [PATCH] D97572: [libc++] Include <__config_site> from <__config>

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/cmake/Modules/HandleLibCXXABI.cmake:55
 
-        if (LIBCXX_HEADER_DIR)
-          set(dst "${LIBCXX_HEADER_DIR}/include/c++/v1/${dstdir}/${fpath}")
+        if (LIBCXX_GENERATED_INCLUDE_DIR) # always true
+          # TODO: libc++ shouldn't be responsible for copying the libc++abi
----------------
curdeius wrote:
> If it's always true, then the condition should be removed, no?
I think at the time it was an attempt to make the diff as small as possible, since that change was already very risky. If we manage to split this out into smaller patches, then yeah, I think we could probably just remove this `if` and unconditionally execute its body.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97572/new/

https://reviews.llvm.org/D97572