[libcxx-commits] [PATCH] D62641: Support arrays in make_shared and allocate_shared (P0674R1)
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Mar 1 10:33:01 PST 2021
ldionne added inline comments.
Comment at: libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/create_array.pass.cpp:10
+// UNSUPPORTED: c++03, c++11, c++14, c++17
+// UNSUPPORTED: sanitizer-new-delete
> I really don't like disabling this whole test for `sanitizer-new-delete`. We need this because of the `globalMemCounter` tests. This is the same thing the unique_ptr tests use.
> @ldionne do you know if there's a macro or some other way we can detect if we're running on `sanitizer-new-delete`? If so, we could just disable the two tests that actually cause this to fail.
I don't think there's such a macro. You could split it off into its own test file if you wanted.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits