[libcxx-commits] [PATCH] D96786: Including <ciso646> should result in an #error since C++17

Mon Mar 1 10:29:37 PST 2021

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Please make the change in all the headers (`<cstdbool>`, etc.). I'll then take that change and compile a significant code base internally with it and we'll see how much trouble it causes. That'll allow us to better evaluate the disruptive potential for this change.

================
Comment at: libcxx/include/ciso646:21
 #pragma GCC system_header
 #endif
 #endif  // _LIBCPP_CISO646
----------------
Also, please use the following wording:

```
#error "C++17 removed the <ciso646> header. If you're trying to detect the Standard library, include <version> instead"
```

You could also add similar wording for the other headers (for example tell users to use `<stdbool.h>` instead of `<cstdbool>`).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96786/new/

https://reviews.llvm.org/D96786