[libcxx-commits] [PATCH] D96786: Including <ciso646> should result in an #error since C++17

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

I'm unsure of the value of doing this vs the amount of breakage it may cause.

There's no doubt that your change is in line with the Standard, I'm just wondering whether it would cause wide trouble without having that much of a practical benefit. In practice, I'm pretty sure this is going to break some open source libraries like Boost which I think have been using `#include <ciso646>` to detect the standard library (that used to be true for some Boost libraries at some point, at least). Also, both MSVC and libstdc++ do provide those headers.

@mclow.lists do you have an opinion about this change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96786/new/

https://reviews.llvm.org/D96786