[libcxx-commits] [PATCH] D102632: [libcxx/cxxabi/unwind][AIX] Add an AIX target and config for testing.

[Sean Fertile via Phabricator via libcxx-commits]

sfertile added a comment.

In D102632#2787406 <https://reviews.llvm.org/D102632#2787406>, @jasonliu wrote:

> LGTM on AIX perspective. 
> FYI, we will need two reviewers from libc++ review group or the maintainer of libc++ project to approve before we could land.

Thanks for the review Jason. @ldionne Can we get a review from you or someone else familiar with the libc++ project?



================
Comment at: libcxx/utils/libcxx/test/target_info.py:163
+    def add_cxx_link_flags(self, flags):
+        flags += ['-lpthread', '-lc++abi', '-lunwind', '-latomic']
+
----------------
jasonliu wrote:
> Just noting that this setup only works when we use libc++/libc++abi/libunwind stack.
> In theory, libc++ could work with gcc and use what's in libstdc++ to replace libc++abi and libunwind. If that's the case, then this won't work any more. And we would need something similar to `LinuxLocalTI` above.
> But I guess people have intention to make the above combination work could change this setup later when they needed. 
Valid point. I think we need to start somewhere though, and we need to enable testing in both libc++abi and libunwind on AIX so we can test Xings patches, so this is the natural first step.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102632/new/

https://reviews.llvm.org/D102632