[libcxx-commits] [PATCH] D103425: [libc++][format] Adds string formatter.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 29 11:31:49 PDT 2021


Mordante updated this revision to Diff 355311.
Mordante marked 6 inline comments as done.
Mordante edited the summary of this revision.
Mordante added a comment.

Addresses review comments and other changes:

- remove `std::pair`
- improve comments
- change the value of no precision `-1` instead of `__number_max`
- merge the class `__parser_string` with `__formatter_string`
- allow precision < width as required by the Standard
- update the module map
- integrate changes done before in the patch series


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103425/new/

https://reviews.llvm.org/D103425

Files:
  libcxx/include/CMakeLists.txt
  libcxx/include/__format/formatter.h
  libcxx/include/__format/formatter_string.h
  libcxx/include/__format/parser_std_format_spec.h
  libcxx/include/format
  libcxx/include/module.modulemap
  libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.c_string.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.const_char_array.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.string.pass.cpp
  libcxx/test/std/utilities/format/format.functions/format.pass.cpp
  libcxx/test/std/utilities/format/format.functions/formatted_size.pass.cpp
  libcxx/test/std/utilities/format/format.functions/tests.inc
  libcxx/test/std/utilities/format/format.functions/vformat.pass.cpp
  libcxx/test/std/utilities/format/format.string/format.string.std/std_format_spec_string.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103425.355311.patch
Type: text/x-patch
Size: 41854 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210629/d470968c/attachment-0001.bin>


More information about the libcxx-commits mailing list