[libcxx-commits] [PATCH] D103056: [libcxx][ranges] Add `ranges::transform_view`.

[Tim Song via Phabricator via libcxx-commits]

tcanens added inline comments.


================
Comment at: libcxx/include/__ranges/transform_view.h:60-61
+
+  _View __base_ = _View();
+  __copyable_box<_Fn> __func_;
+
----------------
Quuxplusone wrote:
> My intuition is that you want to switch these around:
> ```
> [[no_unique_address]] __copyable_box<_Fn> __func_;
> _View __base_ = _View();
> ```
> However, I remember @tcanens having counterintuitive-but-correct intuitions about field ordering in other reviews. It would be useful to write those down as guidelines, somewhere. I volunteer to blog it, if someone can explain it to me until I remember it. :)
After LWG3549 this doesn't really matter.


================
Comment at: libcxx/include/__ranges/transform_view.h:295
+
+  friend constexpr void iter_swap(const __iterator& __x, const __iterator& __y)
+    noexcept(noexcept(ranges::iter_swap(__x.__current_, __y.__current_)))
----------------
This has been removed by LWG3520.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103056/new/

https://reviews.llvm.org/D103056