[libcxx-commits] [PATCH] D103413: [libc++][format] Implement Unicode support.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante updated this revision to Diff 355269.
Mordante marked 4 inline comments as done.
Mordante edited the summary of this revision.
Mordante added a comment.

Addresses part of the review comments:

- Use code units instead of characters in the comments
- Remove the usage of `std::pair`
- Precision == -1 is no precision instead of `__number_max`
- Allow a precision less than the width

The other comments will be addressed later, I want to update the rest of the ser
ies before focussing on these issues:

- Improve the threshold algorithm
- See whether the long returns can be improved without performance degradations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103413/new/

https://reviews.llvm.org/D103413

Files:
  libcxx/benchmarks/CMakeLists.txt
  libcxx/benchmarks/std_format_spec_string_unicode.bench.cpp
  libcxx/docs/Cxx2aStatusPaperStatus.csv
  libcxx/include/__format/parser_std_format_spec.h
  libcxx/test/std/utilities/format/format.string/format.string.std/std_format_spec_string_unicode.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103413.355269.patch
Type: text/x-patch
Size: 41440 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210629/ea211374/attachment-0001.bin>