[libcxx-commits] [PATCH] D104748: [SystemZ][z/OS][libcxx]: fix libcxx test cases failed on ebcdic mode on z/OS

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

I'm fine with this change because of this:

> @SeanP said:
> It is only a few tests like this one that has a built in assumption about the ordering of the subgroups (eg. lower case letters) within the character encoding that are failing.

Otherwise, I think it would have been useful to have a discussion about how to handle those gracefully without introducing a lot of complexity into the test suite. If that's just a few changes, I think it's not worth wasting time over that and we should just find a simple way to fix the tests on a case by case basis.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104748/new/

https://reviews.llvm.org/D104748