[libcxx-commits] [PATCH] D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Almost LGTM, the only issue I have with this is the duplication of the `atomic_helpers.h` header, for which there's a better solution available.



================
Comment at: libcxx/test/std/atomics/atomic_helpers.h:1
+//===----------------------------------------------------------------------===//
+//
----------------
Why are we duplicating this file? Instead, let's move the original file to `libcxx/test/support/atomic_helpers.h` and include it as just `#include "atomic_helpers.h"` from everywhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102992/new/

https://reviews.llvm.org/D102992