[libcxx-commits] [PATCH] D104492: [libc++][pstl] Implement tag dispatching

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added inline comments.


================
Comment at: pstl/include/pstl/internal/algorithm_fwd.h:19
 
 _PSTL_HIDE_FROM_ABI_PUSH
 
----------------
Quuxplusone wrote:
> I believe you need to add `pstl/include` to
> https://github.com/google/llvm-premerge-checks/blob/main/scripts/clang-tidy.ignore
> (Although why this file is in a Google repo instead of the llvm-project repo, I don't know!)
Additionally, it looks like these files may be nested one level too deep. I think this should be `pstl/include/algorithm_fwd.h` not `pstl/include/pstl/include/algorithm_fwd.h`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104492/new/

https://reviews.llvm.org/D104492