[libcxx-commits] [PATCH] D104002: [libcxx][modularisation] splits `<utility>` into self-contained headers

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added a comment.

In D104002#2830844 <https://reviews.llvm.org/D104002#2830844>, @ldionne wrote:

> In D104002#2809564 <https://reviews.llvm.org/D104002#2809564>, @cjdb wrote:
>
>> In D104002#2809545 <https://reviews.llvm.org/D104002#2809545>, @Quuxplusone wrote:
>>
>>> Moving `unary_function` without also moving `binary_function` is unusual.
>>
>> I suggest you carefully read the changes to learn why I didn't move `binary_function` out of `<utility>`. Seriously, I have a good reason.
>
> I assume you're going to move `binary_function` out of `__functional_base` eventually, when we break up that header?

Yes. It would be strange to start splitting up `__functional_base` in a commit concerned with splitting `<utility>`.

> Did you make any changes to the code itself? Assuming you did not, this LGTM with the two indentation nitpicks fixed and the CI passing.

No changes to the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104002/new/

https://reviews.llvm.org/D104002