[libcxx-commits] [PATCH] D96664: [libc++][format] Implement formatters.

[Victor Zverovich via Phabricator via libcxx-commits]

vitaut added inline comments.


================
Comment at: libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.bool.pass.cpp:13-17
+// For each charT, for each cv-unqualified arithmetic type ArithmeticT other
+// than char, wchar_t, char8_t, char16_t, or char32_t, a specialization
+// - a specialization template<> struct formatter<ArithmeticT, charT>;
+// Implemants ArithmeticT is
+// - bool
----------------
Mordante wrote:
> vitaut wrote:
> > I'm not sure how to parse this comment. Is something missing here?
> This is part of the standard wording of the part tested.
The confusing to me part is that "a specialization" appears twice. I suggest replacing `a specialization template<> struct formatter<ArithmeticT, charT>;` with `template<> struct formatter<ArithmeticT, charT>;`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96664/new/

https://reviews.llvm.org/D96664