[libcxx-commits] [PATCH] D102135: [libcxx][ranges] adds _`copyable-box`_

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 23 10:33:39 PDT 2021


cjdb marked 3 inline comments as done.
cjdb added inline comments.


================
Comment at: libcxx/include/__ranges/semiregular_box.h:55
+    {
+      if (other) {
+        optional<_Tp>::emplace(*other);
----------------
Mordante wrote:
> Please remove the braces when the `if` has a single statement.
Not done, I find it more readable to keep braces for all control structures.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102135/new/

https://reviews.llvm.org/D102135



More information about the libcxx-commits mailing list