[libcxx-commits] [PATCH] D104746: [libc++] Remove ad-hoc modules tests that are now unnecessary

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 22 16:27:32 PDT 2021


ldionne added inline comments.


================
Comment at: libcxx/test/libcxx/modules/cinttypes_exports.compile.pass.cpp:24-28
-#include <cinttypes>
-
-int main(int, char**) {
-  int8_t x; (void)x;
-  std::int8_t y; (void)y;
----------------
Quuxplusone wrote:
> I'd feel better if the commit message explicitly pointed to an existing `libcxx/test/` test that would verify this same behavior (namely, that I can use either `int8_t` or `std::int8_t` after including nothing but `<cinttypes>`). However, IMHO this is still fine to clean up, regardless.
See `libcxx/test/std/input.output/file.streams/c.files/cinttypes.pass.cpp`. For each header we remove in `libcxx/test/modules`, I grepped for the corresponding test in `libcxx/test/std` and found one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104746/new/

https://reviews.llvm.org/D104746



More information about the libcxx-commits mailing list