[libcxx-commits] [PATCH] D104669: [libc++] Split the various iterator types out of <iterator>

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 22 16:20:38 PDT 2021


ldionne added a comment.

In D104669#2833736 <https://reviews.llvm.org/D104669#2833736>, @ldionne wrote:

> Note: I am expecting this to fail in the Modules build because I did not add the relevant files to the modulemap. If it doesn't fail, I'll raise an eyebrow.

The modules build doesn't fail - it's a bit suspicious, but as Arthur said in an offline conversation, it appears that those modulemap changes are only necessary when there is some sort of specialization of a type defined in another header or something like that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104669/new/

https://reviews.llvm.org/D104669



More information about the libcxx-commits mailing list