[libcxx-commits] [PATCH] D104746: [libc++] Remove ad-hoc modules tests that are now unnecessary

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
Herald added a subscriber: arichardson.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Since we now have modules-enabled CI, it is now redundant to have ad-hoc
tests that check arbitrary things about our modules support. Instead,
the whole test suite should pass with modules enabled, period.

This patch also removes the module cache path workaround: one would
expect that modules work properly without that workaround. If that
isn't the case and we do run into flaky test failures, we can re-enable
the workaround temporarily (but that would be very vexing and we should
fix Clang ASAP if that's the case).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D104746

Files:
  libcxx/test/libcxx/modules/cinttypes_exports.compile.pass.cpp
  libcxx/test/libcxx/modules/clocale_exports.compile.pass.cpp
  libcxx/test/libcxx/modules/cstdint_exports.compile.pass.cpp
  libcxx/test/libcxx/modules/inttypes_h_exports.compile.pass.cpp
  libcxx/test/libcxx/modules/stdint_h_exports.compile.pass.cpp
  libcxx/test/libcxx/modules/stds_include.sh.cpp
  libcxx/utils/libcxx/test/features.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104746.353779.patch
Type: text/x-patch
Size: 9726 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210622/7347bbb4/attachment-0001.bin>