[libcxx-commits] [PATCH] D103734: [libcxx][modularisation] moves <utility> content out of <type_traits>

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 22 13:40:42 PDT 2021


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM w/ comment.



================
Comment at: libcxx/include/__algorithm/swap_ranges.h:27
+#ifndef _LIBCPP_CXX03_LANG
+    typename enable_if<is_move_constructible<_Tp>::value && is_move_assignable<_Tp>::value>::type
+#else
----------------
This forward declaration isn't using the `__swap_result_t` you factored out. I think you should include `__utility/swap.h` here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103734/new/

https://reviews.llvm.org/D103734



More information about the libcxx-commits mailing list