[libcxx-commits] [PATCH] D57688: [libcxx] Remove <ext/hash_set>, <ext/hash_map> and <ext/__hash>

Duncan P. N. Exon Smith via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 22 11:27:07 PDT 2021


dexonsmith added a comment.

In D57688#2833512 <https://reviews.llvm.org/D57688#2833512>, @ldionne wrote:

> I might revisit this later, but I'm not moving forward for the time being since a bunch of people said it was going to break them.
>
> I think we should instead ship those headers as a separate project and people who need them can still get the headers from that project. IOW, they shouldn't be part of libcxx. But I don't have any time to work on this low priority cleanup at the moment, so abandoning.

Another option to consider, if/when this is revisited, is leaving them in libcxx but shipping them only as a (maybe off-by-default?) cmake configuration option.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57688/new/

https://reviews.llvm.org/D57688



More information about the libcxx-commits mailing list