[libcxx-commits] [PATCH] D104669: [libc++] Split the various iterator types out of <iterator>

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/__iterator/wrap_iter.h:78-81
+template <class _Ip, class _Op> _Op _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX17 copy(_Ip, _Ip, _Op);
+template <class _B1, class _B2> _B2 _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX17 copy_backward(_B1, _B1, _B2);
+template <class _Ip, class _Op> _Op _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX17 move(_Ip, _Ip, _Op);
+template <class _B1, class _B2> _B2 _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX17 move_backward(_B1, _B1, _B2);
----------------
Quuxplusone wrote:
> I suppose this is just shuffling code around, so OK; but it would make a good followup to investigate why these 4 lines are here, and what breaks if they're removed (if anything). I suspect they're obsolete.
> Bonus points if you make all the `operator<=` etc. into hidden friends, thus shortening this file by a few dozen lines.
I planned on doing that, thanks for reminding me.

Those forward declarations are obsolete, I already checked that the other day.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104669/new/

https://reviews.llvm.org/D104669