[libcxx-commits] [PATCH] D104172: [libc++] Remove some obsolete _LIBCPP_CXX03_LANG

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

@ldionne: My impression is that your testing concern applies:

- YES to things like `vector::emplace_back`
- NO to the changes in `<bitset>`
- MAYBE to things like `vector::push_back(value_type&&)`

I think the precedent here is `std/utilities/utility/forward/move.pass.cpp` — libc++ supports `std::move` in C++03 as an extension, so our tests for `std::move` do not say `UNSUPPORTED: c++03`. Instead, they say nothing: the test is simply supported in all modes. I can go through the tests for these facilities and remove `UNSUPPORTED: c++03` where I see it; for example, in `std/containers//sequences/deque/deque.modifiers/emplace_back.pass.cpp`.

It doesn't make sense to add `UNSUPPORTED: c++03 && !libc++` to new code; this is the libc++ test suite, and we do not run it on any other "C++03" libraries. Any other library tested with this test suite should be C++11-or-later already.

I'll also split out the "implementation" changes, that don't have any effects on `libcxx/test/`, into a separate commit/PR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104172/new/

https://reviews.llvm.org/D104172