[libcxx-commits] [PATCH] D100504: [libc++abi][AIX] initial patch for EH on AIX

Jason Liu via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jun 21 07:58:34 PDT 2021


jasonliu added inline comments.


================
Comment at: libcxxabi/src/cxa_personality.cpp:1267
+    if (StateTabDbg())                                                         \
+      fprintf(stderr, "libcxxabi: " _args);                                    \
+  } while (0)
----------------
cebowleratibm wrote:
> jasonliu wrote:
> > fprintf is a function in stdio.h. I think we should include that header, otherwise, changes might not be portable.
> Isn't this on line 1248?
Yes. It wasn't there before my comment. Xing addressed my comment. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100504/new/

https://reviews.llvm.org/D100504



More information about the libcxx-commits mailing list