[libcxx-commits] [PATCH] D102798: [SystemZ][z/OS] XFAIL aligned allocation tests on z/OS

Fri Jun 18 11:43:19 PDT 2021

DanielMcIntosh-IBM added a comment.

In D102798#2827705 <https://reviews.llvm.org/D102798#2827705>, @SeanP wrote:

> In D102798#2825509 <https://reviews.llvm.org/D102798#2825509>, @ldionne wrote:
>
>> LGTM, but just out of curiosity, will this stay unsupported forever, or will this be implemented eventually?
>>
>> Normally, we try to support things unless we have a fundamental reason why it can't be done (for example supporting exceptions on an embedded system). But it seems a bit strange to me to mark aligned allocation function tests as unsupported based on the *architecture* - instead I would have expected it to be marked as unsupported based on specific OS versions that do not implement the feature yet.
>
> As of today z/OS does not support aligned allocation.  Once it is supported we will be able to say it is only supported in z/OS X.Y and above.  The tag "s390-zos" is more than an architecture tag.  It is more of an OS tag.  We have zLinux on s390 as well.  The s390-zos tag only covers z/OS, not zLinux.  We can change that name if it helps clarify some confusion.

I think better than changing the name is changing both the name and regular expression - instead of matching zos on s390 (and variants), just match zos.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102798/new/

https://reviews.llvm.org/D102798