[libcxx-commits] [PATCH] D103769: [libcxx] Implement P0883R2 ("Fixing Atomic Initialization")

[Raul Tambre via Phabricator via libcxx-commits]

tambre marked an inline comment as done.
tambre added inline comments.


================
Comment at: libcxx/test/std/atomics/atomics.types.generic/throw.pass.cpp:29
+  }
+}
----------------
Mordante wrote:
> Quuxplusone wrote:
> > Nice!
> > Nit: please make `main`'s signature `int main(int, char**)` and add `return 0;` at the end. We do this on all `main`s, for some reason related to testing on embedded platforms.
> This comment hasn't been addressed yet.
I do seem to have addressed this. Am I missing something?
I've now updated the deprecation test to not use `main()` since it doesn't need to be run in case if that's what you meant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103769/new/

https://reviews.llvm.org/D103769