[libcxx-commits] [PATCH] D102809: [libcxx][ranges] Add `ranges::iter_swap`.

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 17 10:22:24 PDT 2021


cjdb added a comment.

I'll properly review this tonight, but I don't suspect I'll have much more to add now.



================
Comment at: libcxx/include/__iterator/iter_swap.h:55-56
+  struct __fn {
+    template <class _T1, class _T2>
+      requires __unqualified_iter_swap<_T1, _T2>
+    constexpr void operator()(_T1&& __x, _T2&& __y) const
----------------
ldionne wrote:
> zoecarver wrote:
> > cjdb wrote:
> > > 
> > This is a bit more confusing imho. If you feel strongly I'll change it, though. 
> Agreed, I would definitely keep as-is.
FYI: we're going to be doing this in a lot of algorithms, and it's definitely part of the design of concepts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102809/new/

https://reviews.llvm.org/D102809



More information about the libcxx-commits mailing list