[libcxx-commits] [PATCH] D104315: [libc++] Promote GCC 11 to mandatory CI

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/utils/ci/Dockerfile:61
 
-# Install a recent GCC
+# Install the most recently released GCC
 RUN add-apt-repository ppa:ubuntu-toolchain-r/test
----------------
ldionne wrote:
> Quuxplusone wrote:
> > I'd leave this comment as "a recent GCC", since otherwise it'll be lying in a few months from now.
> Actually, I think it's important to document the intent here. See my next update, hopefully it makes it clearer what we're trying to do.
OK, I buy this new phrasing. LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104315/new/

https://reviews.llvm.org/D104315