[libcxx-commits] [PATCH] D104328: [libc++] Always build libc++ and libc++abi with -fPIC

[Saleem Abdulrasool via Phabricator via libcxx-commits]

compnerd added inline comments.


================
Comment at: libcxx/src/CMakeLists.txt:276
       OUTPUT_NAME   "c++"
+      POSITION_INDEPENDENT_CODE ON
   )
----------------
Why build the static library as PIC?  It is going to be statically linked so it doesn't really need to be position independent.  Even if you were to statically link the library into a shared library, it would basically be fully internalized, and the linker should be able to lay it out so that you don't need the PLT/GOT indirection.


================
Comment at: libcxxabi/src/CMakeLists.txt:263
+                          POSITION_INDEPENDENT_CODE
+                            ON)
 
----------------
Similar


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104328/new/

https://reviews.llvm.org/D104328