[libcxx-commits] [PATCH] D104315: [libc++] Promote GCC 11 to mandatory CI

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_is_lock_free.pass.cpp:30-32
+    A t = T();
     bool b1 = std::atomic_is_lock_free(static_cast<const A*>(&t));
     volatile A vt;
----------------
Whatever change is made to `t` probably also needs to be made to `vt`.
D103769 is vaguely related.


================
Comment at: libcxx/utils/ci/Dockerfile:61
 
-# Install a recent GCC
+# Install the most recently released GCC
 RUN add-apt-repository ppa:ubuntu-toolchain-r/test
----------------
I'd leave this comment as "a recent GCC", since otherwise it'll be lying in a few months from now.


================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:138-149
-  - label: "GCC-next/C++20"
-    command: "libcxx/utils/ci/run-buildbot generic-gcc-next"
-    artifact_paths:
-      - "**/test-results.xml"
-    agents:
-      queue: "libcxx-builders"
-    retry:
----------------
Would it be an unconscionable waste of buildkite resources to just leave this here, and update the `gcc-next` target to GCC 12 when it's released? As with the comment above, it seems silly to be churning this stuff around twice per GCC-release-cycle, when we could get away with updating it just once per GCC-release-cycle.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104315/new/

https://reviews.llvm.org/D104315