[libcxx-commits] [PATCH] D100132: [libunwind][AIX] implementation of the unwinder for AIX

Tue Jun 15 10:55:36 PDT 2021

sfertile added inline comments.

================
Comment at: libunwind/src/assembly.h:224
+#define DEFINE_LIBUNWIND_FUNCTION(name)                                        \
+  .toc SEPARATOR                                                               \
+  .globl name SEPARATOR                                                        \
----------------
Sorry, I seem to have deleted this comment before submitting my last set of comments. Its extra emabahrasing because one of the comments I left referred to this one :(.

The .toc pseudo is only needed once per file that includes this header, not really once per function being defined (although the extras are harmless). We have a change at the top of the 2 files that include assembly.h to not emit the `.text` directive, we can instead change that to emit the .toc directive on AIX and delete the .toc directive from this macro and `DEFINE_LIBUNWIND_FUNCTION_AND_WEAKALIAS`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100132/new/

https://reviews.llvm.org/D100132