[libcxx-commits] [PATCH] D104175: [libcxx][iwyu] ensures we IWYU as prep for modules

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jun 14 10:58:41 PDT 2021


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM but can you please move the `operator&` changes to the other patch? Also, I think this does reduce the usefulness of `__function_like` by quite a bit, cause now we have to think about adding a declaration in the function objects *and* derive from `__function_like`. I think we should fix the underlying modules bug (seriously, modules shouldn't have anything to do with this!) and more `operator&` back into `__function_like`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104175/new/

https://reviews.llvm.org/D104175



More information about the libcxx-commits mailing list