[libcxx-commits] [PATCH] D100132: [libunwind][AIX] Initial patch of the unwinder on AIX

Sean Fertile via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jun 14 08:52:58 PDT 2021


sfertile added inline comments.


================
Comment at: libunwind/src/Unwind_AIXExtras.cpp:31
+  // Get to the name of the function.
+  if (TBTable->tb.name_present) {
+    p = (uint32_t *)&TBTable->tb_ext;
----------------
Switch the order here and early return if the name is not present.

ie 
```
if (!TBTable->tb.name_present)
  return NULL

// Get the name of the function.
...
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100132/new/

https://reviews.llvm.org/D100132



More information about the libcxx-commits mailing list