[libcxx-commits] [PATCH] D104175: [libcxx][iwyu] ensures we IWYU for __iterator, __memory, and __ranges

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/include/__memory/allocator_traits.h:360-363
 // __is_default_allocator
 template <class _Tp>
 struct __is_default_allocator : false_type { };
 
----------------
All the `#include` changes look fine to me, but I question the wisdom of(*) splitting up the specializations of `__is_default_allocator`. Generally for a type-trait we want to keep the "true" and "false" branches together in the same file.
So, please don't make this diff. Either leave it as-is, or, if you really can't get the modules build building without a diff here, make the diff to add
```
template <class _Tp> class allocator;
```
right above line 360.

(* yes, this is understatement)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104175/new/

https://reviews.llvm.org/D104175