[libcxx-commits] [PATCH] D104048: [libc++] NFC: Move indirect_concepts.h to __iterator/concepts.h

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jun 11 09:56:45 PDT 2021


ldionne added a comment.

In D104048#2812311 <https://reviews.llvm.org/D104048#2812311>, @Quuxplusone wrote:

> LGTM. But btw, what's going on with these GCC failures? I thought you (@ldionne) were going to fix them, but it's been like a month now. Should I make a PR for it? Some of these failures are just straight up typos in the test cases; others might require some digging, I don't know (which is why I was happy to let you deal with it, I thought).

There's been a lot going on in the past few weeks (notably with CI failures) and I have not had time to finish that up yet. Feel free to pick it up if you want (but don't touch the `ranges::prev/ranges::next` failures since I have a patch for that I'm finishing up).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104048/new/

https://reviews.llvm.org/D104048



More information about the libcxx-commits mailing list