[libcxx-commits] [PATCH] D102468: [libcxx][ranges] removes default_initializable from weakly_incrementable and view

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver accepted this revision as: zoecarver.
zoecarver added a comment.

Let's land this to unblock the other patches.



================
Comment at: libcxx/include/iterator:919
     _Container* container;
-    typename _Container::iterator iter;
+    typename _Container::iterator iter; // FIXME: `ranges::iterator_t<Container>` in C++20 mode
 public:
----------------
Quuxplusone wrote:
> cjdb wrote:
> > ldionne wrote:
> > > Why a FIXME instead of `#if _LIBCPP_STD_VER > XXXX`?
> > > 
> > > If both types exist, then they should be the same, so I don't see any sort of ABI issue in case that was the concern.
> > I want to put this in a more relevant patch.
> I agree with Louis's assessment here.
Theoretically there's a section in the ranges status document to track things like this... but I guess we don't really use it.

Anyway, please make sure you have this on some todo list that you're going to look at at some point (or put it in the ranges status doc). Make sure it's not just a browser tab ;)


================
Comment at: libcxx/include/string_view:662
+template <class _CharT, class _Traits>
+inline constexpr bool ranges::enable_view<basic_string_view<_CharT, _Traits>> = true;
+
----------------
Why are we putting this change in this patch. I feel like this should be its own patch. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102468/new/

https://reviews.llvm.org/D102468