[libcxx-commits] [PATCH] D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

In D103947#2809046 <https://reviews.llvm.org/D103947#2809046>, @mstorsjo wrote:

> In D103947#2808999 <https://reviews.llvm.org/D103947#2808999>, @rnk wrote:
>
>> I think we can say that `_HAS_EXCEPTIONS=0` is an important configuration.
>
> Oh, that's good to know, thanks for clarifying it!
>
>> I can't speak to or improve the state of libc++ testing, but I think we'd start using this configuration if libc++ supported it. We have plans to work on Windows testing in LLVM, and that might include libc++, but the timeline is early 2022, so I'm not sure we should wait for that.
>
> So I guess it's mostly up to @goncharov and the resources of the current windows runners and how much load they have from the current CI setups (from what I've seen lately, they run their tasks with little to no wait so they seem fine?), whether it's ok to add another config. If it is, I could try looking into adding a config for this.

I'm not sure if it's of any help, but we will also cover this configuration in our CI since we want to start building and distributing Clang toolchain for Windows to our partners; this issue is actually our last blocker.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103947/new/

https://reviews.llvm.org/D103947