[libcxx-commits] [PATCH] D102468: [libcxx][ranges] removes default_initializable from weakly_incrementable and view

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added inline comments.


================
Comment at: libcxx/test/std/ranges/range.req/range.view/view.subsumption.verify.cpp:55-65
 namespace subsume_default_initializable {
-  template <std::ranges::view>
-  constexpr bool test() { return true; }
-  template <std::default_initializable>
-  constexpr bool test() { return false; }
-  static_assert(test<View>());
+template <std::ranges::view>
+constexpr bool test() {
+  return true;
+}
+template <std::default_initializable>
+constexpr bool test() {
----------------
cjdb wrote:
> Quuxplusone wrote:
> > This test is now wrong. Please remove lines 55-65, and undo the file move.
> Why is it wrong?
Don't worry, I understand now (for future readers: the test is not necessary since the change on `libcxx/test/std/ranges/range.req/range.view/view.compile.pass.cpp:49` acts as the regression test). This applies to `libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.winc/subsumption.verify.cpp:33` as well.

@Quuxplusone In future, could you please explain why you think something is wrong instead of matter-of-factly stating it? I had no context, and from what I could see, the test looked correct to me.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102468/new/

https://reviews.llvm.org/D102468