[libcxx-commits] [PATCH] D102468: [libcxx][ranges] removes default_initializable from weakly_incrementable and view
Christopher Di Bella via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Jun 10 10:18:21 PDT 2021
cjdb added inline comments.
================
Comment at: libcxx/include/iterator:919
_Container* container;
- typename _Container::iterator iter;
+ typename _Container::iterator iter; // FIXME: `ranges::iterator_t<Container>` in C++20 mode
public:
----------------
ldionne wrote:
> Why a FIXME instead of `#if _LIBCPP_STD_VER > XXXX`?
>
> If both types exist, then they should be the same, so I don't see any sort of ABI issue in case that was the concern.
I want to put this in a more relevant patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102468/new/
https://reviews.llvm.org/D102468
More information about the libcxx-commits
mailing list