[libcxx-commits] [PATCH] D103973: [libc++abi] Remove the LIBCXXABI_ENABLE_PIC option

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 10 09:26:08 PDT 2021


ldionne added a comment.

In D103973#2808513 <https://reviews.llvm.org/D103973#2808513>, @sbc100 wrote:

> wasm-ld has since been improved so its now possible to link PIC objects into static binaries.    This means this is way less of an issue for WebAssembly these days.   Plus I no longer maintain the toolchain that was using these CMake files to build libc++abi.
>
> So I think I fine with removing this option, especially in light the "Runtimes" build which IIUC any modern toolchain builders should be using anyway.

Thanks for your input!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103973/new/

https://reviews.llvm.org/D103973



More information about the libcxx-commits mailing list