[libcxx-commits] [PATCH] D102468: [libcxx][ranges] removes default_initializable from weakly_incrementable and view

Thu Jun 10 09:24:27 PDT 2021

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

We'll also need to remember to bump the `__cpp_lib_ranges` feature-test macro to the right version when we do that (which I assume is when we'll have finished Ranges since we haven't discussed it).

Also, as discussed offline, please make the `enable_view.h` move in a separate NFC commit to reduce noise.

In D102468#2810753 <https://reviews.llvm.org/D102468#2810753>, @Quuxplusone wrote:

> If we're doing p2325 here now, then this patch should include changes to `ostream_iterator` and so on. (I think it would have been better to ship the LGTM'ed patch and then work on p2325 in a new PR; is that still an option, or is the old code lost now?)

The patch I'm looking at right now does include the required changes to `ostream_iterator`, unless you're talking about other changes I'm not seeing?

================
Comment at: libcxx/include/iterator:919
     _Container* container;
-    typename _Container::iterator iter;
+    typename _Container::iterator iter; // FIXME: `ranges::iterator_t<Container>` in C++20 mode
 public:
----------------
Why a FIXME instead of `#if _LIBCPP_STD_VER > XXXX`?

If both types exist, then they should be the same, so I don't see any sort of ABI issue in case that was the concern.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102468/new/

https://reviews.llvm.org/D102468